Allow comment deletion via nested attributes#1358
Merged
Conversation
Enable allow_destroy on accepts_nested_attributes_for :comments across all commentable models (Person, User, Organization, EventRegistration) and permit :_destroy in their controllers. Adds a "Remove" link to the comment fields partial. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
maebeale
added a commit
that referenced
this pull request
Mar 9, 2026
* Allow comment deletion via nested attributes Enable allow_destroy on accepts_nested_attributes_for :comments across all commentable models (Person, User, Organization, EventRegistration) and permit :_destroy in their controllers. Adds a "Remove" link to the comment fields partial. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Show Remove button only in comment edit mode Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR and why is this important?
How did you approach the change?
allow_destroy: truetoaccepts_nested_attributes_for :commentson all 4 commentable models:_destroyincomments_attributesstrong params in People, Users, and Organizations controllers (EventRegistrations already had it)_comment_fields.html.erbpartial, matching the style used for affiliationsUI Testing Checklist
🤖 Generated with Claude Code